feat: remove internal processors + contracts#920
Open
brendanobra wants to merge 3 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the RippleContract::Internal enum variant to RippleContract::RippleContext to better reflect its purpose as an internal platform context for message passing between Main and Extensions. The change includes updating the documentation and moving the #[default] attribute to maintain the correct default value.
- Renamed
RippleContract::InternaltoRippleContract::RippleContextwith improved documentation - Updated all references throughout the codebase including production code, tests, and mock utilities
- Moved the
#[default]attribute to the new variant to preserve default behavior
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/sdk/src/framework/ripple_contract.rs | Renamed enum variant from Internal to RippleContext and updated documentation |
| core/sdk/src/utils/mock_utils.rs | Updated mock utilities to use RippleContext |
| core/sdk/src/extn/extn_client_message.rs | Updated ExtnPayloadProvider implementations and test assertions |
| core/sdk/src/extn/client/wait_for_service_processor.rs | Updated test messages to use RippleContext |
| core/sdk/src/extn/client/extn_processor.rs | Updated test state and assertions to use RippleContext |
| core/sdk/src/extn/client/extn_client.rs | Updated all test cases and processor initializations to use RippleContext |
| core/main/src/service/ripple_service/service_controller_state.rs | Updated error message handling to use RippleContext |
| core/main/src/firebolt/firebolt_ws.rs | Updated error message handling to use RippleContext |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| payload: ExtnPayload::Response(ExtnResponse::Error(e)), | ||
| requestor: ExtnId::try_from(session.get_app_id()).unwrap(), | ||
| target: RippleContract::Internal, | ||
| target: RippleContract::RippleContext, |
Contributor
There was a problem hiding this comment.
We should not be sending any ExtnMessage here. Instead use service message for propagating this error as JSON RPC error response.
| id: "test_id".to_string(), | ||
| requestor: ExtnId::get_main_target("main".into()), | ||
| target: RippleContract::Internal, | ||
| target: RippleContract::RippleContext, |
Contributor
There was a problem hiding this comment.
The scope of this ticket is to eliminate the use of RippleContract::Internal and switch to direct function calls or rule-based invocation. These tests are no longer relevant since we are removing the use of ExtnMessages.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist